Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] LDAP Sync error #17417

Merged
merged 1 commit into from
Apr 24, 2020
Merged

[FIX] LDAP Sync error #17417

merged 1 commit into from
Apr 24, 2020

Conversation

fastrde
Copy link
Contributor

@fastrde fastrde commented Apr 24, 2020

Closes #17363

In loginHelper.js the function addLdapUser from sync.js was called with the wrong argument count. The reference to ldap was missing, so searchAllSync got called on undefined

Function signature in sync.js:

export function addLdapUser(ldapUser, username, password, ldap) {...}

Call in loginHelper.js:

const result = addLdapUser(ldapUser, username, loginRequest.ldapPass);

Fix:

const result = addLdapUser(ldapUser, username, loginRequest.ldapPass, ldap);

That's it.

@sampaiodiego sampaiodiego changed the title [FIX] for issue #17363 [FIX] LDAP Sync error Apr 24, 2020
@sampaiodiego sampaiodiego added this to the 3.1.2 milestone Apr 24, 2020
@sampaiodiego sampaiodiego merged commit 7a2adb9 into RocketChat:develop Apr 24, 2020
sampaiodiego pushed a commit that referenced this pull request Apr 27, 2020
@sampaiodiego sampaiodiego mentioned this pull request Apr 27, 2020
ggazzo added a commit that referenced this pull request Apr 28, 2020
…to adm/custom_status

* 'admin-refactor' of github.com:RocketChat/Rocket.Chat:
  [IMPROVE] Redesign Administration > Invites (#17390)
  Bump version to 3.1.2
  [FIX] LDAP error when trying to add room with spaces in the name (#17453)
  Regression: Add missing cacheKey to mem (#17430)
  [FIX] Empty Incoming webhook script field (#17422)
  [FIX] LDAP Sync error (#17417)
  [FIX] Bot Agents not being able to get Omnichannel Inquiries (#17404)
  [FIX] Allowing blocking a user on channels (#17406)
  Regression: Fix mem usage with more than one argument (#17391)
  [FIX] Web Client memory leak caused by the Emoji library (#17320)
  [FIX] Omnichannel room info panel opening whenever a message is sent (#17348)
  [FIX] New user added by admin doesn't receive random password email (#17249)
  [FIX] LDAP error when trying to add room with spaces in the name (#17453)
  Complement Guest role restrictions for Enterprise (#17393)
  Regression: Add missing cacheKey to mem (#17430)
  Remove `@typescript-eslint/explicit-function-return-type` rule (#17428)
  [FIX] Empty Incoming webhook script field (#17422)
  [FIX] LDAP Sync error (#17417)
  [FIX] Bot Agents not being able to get Omnichannel Inquiries (#17404)
ggazzo added a commit that referenced this pull request May 6, 2020
* 'develop' of github.com:RocketChat/Rocket.Chat: (30 commits)
  [IMPROVE] [Apps-Engine] App user as the default notifier (#17050)
  [NEW] [Apps-Engine] New Livechat event handlers (#17033)
  [FIX] Change email verification label (#17450)
  Priority system messages were always created (#17479)
  Bump version to 3.3.0-develop
  Bump version to 3.2.0
  Bump version to 3.1.2
  [FIX] LDAP error when trying to add room with spaces in the name (#17453)
  Regression: Add missing cacheKey to mem (#17430)
  [FIX] Empty Incoming webhook script field (#17422)
  [FIX] LDAP Sync error (#17417)
  [FIX] Bot Agents not being able to get Omnichannel Inquiries (#17404)
  [FIX] Allowing blocking a user on channels (#17406)
  Regression: Fix mem usage with more than one argument (#17391)
  [FIX] Web Client memory leak caused by the Emoji library (#17320)
  [FIX] Omnichannel room info panel opening whenever a message is sent (#17348)
  [FIX] New user added by admin doesn't receive random password email (#17249)
  Bump version to 3.2.0-rc.2
  [FIX] LDAP error when trying to add room with spaces in the name (#17453)
  Complement Guest role restrictions for Enterprise (#17393)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenLDAP Group SYNC error
3 participants