[NEW] Custom emoji refactor #17499
Merged
[NEW] Custom emoji refactor #17499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dudizilla
commented
Apr 30, 2020
•
dudizilla
commented
MartinSchoeler
previously requested changes
Apr 30, 2020
|
|
||
| const uploadCustomEmoji = useMethod('uploadCustomEmoji'); | ||
|
|
||
| const saveEmoji = useMethod('insertOrUpdateUserStatus'); |
There was a problem hiding this comment.
insertOrUpdateEmoji
| return soundEmoji; | ||
| }; | ||
|
|
||
| const saveAction = async (newData) => { |
There was a problem hiding this comment.
This method has variables that need to be renamed
….Chat into custom-emoji * 'admin-refactor' of https://github.com/RocketChat/Rocket.Chat: LingoHub based on develop (#17520) RegExp improvements suggested by LGTM (#17500) [FIX] Replace obsolete X-FRAME-OPTIONS header on Livechat route (#17419) [FIX] LDAP login error on Enterprise version (#17497) [IMPROVE] [Apps-Engine] App user as the default notifier (#17050) [NEW] [Apps-Engine] New Livechat event handlers (#17033) [FIX] Change email verification label (#17450) fix: Admin Users Actions (#17469) Fix bad component reference [IMPROVE] Depart from /app/ui-admin (#17464) Priority system messages were always created (#17479) Bump version to 3.3.0-develop Bump version to 3.2.0 Bump version to 3.2.0-rc.2 Bump version to 3.2.0-rc.1 Bump version to 3.2.0-rc.0
ggazzo
approved these changes
May 5, 2020
ggazzo
added a commit
that referenced
this pull request
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.