Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEW] Screen Lock settings - mobile client #17523

Merged
merged 3 commits into from
May 6, 2020
Merged

[NEW] Screen Lock settings - mobile client #17523

merged 3 commits into from
May 6, 2020

Conversation

djorkaeffalexandre
Copy link
Contributor

Screen Shot 2020-05-04 at 14 02 26

ggazzo
ggazzo previously approved these changes May 4, 2020
View reviewed changes
@ggazzo ggazzo added this to the 3.3.0 milestone May 4, 2020
@sampaiodiego
Copy link
Member

I don't know what is happening to GitHub CI 🤔

anyways, I think we should mention this is more than a "Screen lock", it also requests a PIN code when locked.. I've seen an app calling this as "app protection", wdyt?

@diegolmello
Copy link
Member

I don't know what is happening to GitHub CI 🤔

anyways, I think we should mention this is more than a "Screen lock", it also requests a PIN code when locked.. I've seen an app calling this as "app protection", wdyt?

It's "Screen Lock" on WhatsApp and "Passcode Lock" on Telegram.
"App Protection" feels too generic IMO.

@sampaiodiego
Copy link
Member

As much generic as "Screen Lock" :)

The point is, we need to describe a little bit more what it does, regardless the name we chose.

@sampaiodiego sampaiodiego reopened this May 5, 2020
@djorkaeffalexandre
Copy link
Contributor Author

As much generic as "Screen Lock" :)

The point is, we need to describe a little bit more what it does, regardless the name we chose.

@sampaiodiego WDYT?

Screen Shot 2020-05-05 at 17 09 44

@sampaiodiego
Copy link
Member

As much generic as "Screen Lock" :)
The point is, we need to describe a little bit more what it does, regardless the name we chose.

@sampaiodiego WDYT?

Screen Shot 2020-05-05 at 17 09 44

looks good :D

@sampaiodiego sampaiodiego merged commit 01e5a21 into RocketChat:develop May 6, 2020
@djorkaeffalexandre djorkaeffalexandre deleted the new.screen-lock-settings branch May 6, 2020 18:59
ggazzo added a commit that referenced this pull request May 8, 2020
@ggazzo
Merge branch 'feat/new-threads' of github.com:RocketChat/Rocket.Chat …
3ee42b6 
…into feat/new-threads

* 'feat/new-threads' of github.com:RocketChat/Rocket.Chat:
  Regression: RegExp callbacks of settings were not being called (#17552)
  Fix notifications and rooms list updates
  Fix marking closed threads as read
  Meteor update to version 1.10.2 (#17533)
  Fix default offline channel name when saving departments. (#17553)
  [NEW] Screen Lock settings - mobile client (#17523)
ggazzo added a commit that referenced this pull request May 11, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into develop
89f7125 
* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] LDAP login on Enteprise Version (#17508)
  [FIX] Login Forbidden on servers that had LDAP enabled in the past (#17579)
  [FIX] Email configs not updating after setting changes (#17578)
  [FIX] Error during data export for DMs (#17577)
  Regression: Override via env for string settings not working (#17576)
  [FIX] Emoji picker search broken (#17570)
  Add some missing metadata information (#17524)
  Bump jquery from 3.3.1 to 3.5.0 (#17486)
  [NEW] Show user's status description by the usernames in messages list (#14892)
  DPlatform is deprecated and the replacement does not support rocket.chat (#17040)
  Regression: RegExp callbacks of settings were not being called (#17552)
  Meteor update to version 1.10.2 (#17533)
  Fix default offline channel name when saving departments. (#17553)
  [NEW] Screen Lock settings - mobile client (#17523)
ggazzo added a commit that referenced this pull request May 12, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into remo…
1d1bbcd 
…ve-get-dom

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] Push settings enabled when push gateway is selected (#17582)
  [FIX] LDAP login on Enteprise Version (#17508)
  [FIX] Login Forbidden on servers that had LDAP enabled in the past (#17579)
  [FIX] Email configs not updating after setting changes (#17578)
  [FIX] Error during data export for DMs (#17577)
  Regression: Override via env for string settings not working (#17576)
  [FIX] Emoji picker search broken (#17570)
  Add some missing metadata information (#17524)
  Bump jquery from 3.3.1 to 3.5.0 (#17486)
  [NEW] Show user's status description by the usernames in messages list (#14892)
  DPlatform is deprecated and the replacement does not support rocket.chat (#17040)
  Regression: RegExp callbacks of settings were not being called (#17552)
  Meteor update to version 1.10.2 (#17533)
  Fix default offline channel name when saving departments. (#17553)
  [NEW] Screen Lock settings - mobile client (#17523)
This was referenced May 28, 2020
Merged
Merged
@xmxax
Copy link

xmxax commented Sep 14, 2020

Hey there!

Is there any way for an admin to reset someone's PIN?

I have someone claiming the system never asked them to set one up so now they are locked out

@diegolmello
Copy link
Member

diegolmello commented Sep 15, 2020 •
edited
Loading

@xmxax not really.
PIN is saved locally on the device.
Only way is by uninstalling the app and installing it again.

If you need any help, open an issue on our mobile repo https://github.com/RocketChat/Rocket.Chat.ReactNative

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

@ggazzo ggazzo ggazzo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@djorkaeffalexandre @sampaiodiego @diegolmello @xmxax @ggazzo