[FIX] Agent's custom fields being leaked through the Livechat configuration endpoint #17640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcosSpessatto
approved these changes
May 19, 2020
gabriellsh
added a commit
that referenced
this pull request
May 19, 2020
…customFields_users * 'develop' of github.com:RocketChat/Rocket.Chat: [IMPROVE] Add env var to configure Chatpal URL and remove it from beta (#16665) Regression: Set retryWrites=false as default Mongo options (#17683) Fix the leak of agent's custom fields. (#17640) Regression: removed avatar provider temporary [FIX] Avatar url provider ignoring subfolders (#17675) [IMPROVE] Added divider between tables and paginations (#17680) [IMPROVE] Starred Messages (#17685) Regression: status-color-online (#17684)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLOSES #16354
The agent's custom fields were being leaked, there was no treatment as to which fields could be shared with the Livechat widget.
Now we're sharing the agent's custom fields the same way we do through the CRM integrations. There is a field(sendToIntegrations) that allows fields sharing with the Livechat widget.