Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Outgoing List #17667

Merged
merged 7 commits into from
May 16, 2020
Merged

Regression: Outgoing List #17667

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1fb7620
Fix concurrency problem while fetching integration data
ggazzo Apr 24, 2020
04e0635
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into develop
ggazzo Apr 30, 2020
8ac2b5c
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into develop
ggazzo May 6, 2020
89f7125
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into develop
ggazzo May 8, 2020
fad71e6
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into develop
ggazzo May 10, 2020
1d2a6c4
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into develop
ggazzo May 16, 2020
783dc9b
Fix outgoing table
ggazzo May 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/admin/integrations/IntegrationsTable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export function IntegrationsTable({ type }) {
<Th key={'username'} direction={sort[1]} active={sort[0] === 'username'} onClick={onHeaderClick} sort='username'>{t('Post_as')}</Th>,
].filter(Boolean), [sort, isBig]);

const renderRow = useCallback(({ name, _id, type, username, _createdAt, _createdBy: { username: createdBy }, channel }) => {
const renderRow = useCallback(({ name, _id, type, username, _createdAt, _createdBy: { username: createdBy }, channel = [] }) => {
const handler = useMemo(() => onClick(_id, type), []);
return <Table.Row key={_id} onKeyDown={handler} onClick={handler} tabIndex={0} role='link' action>
<Table.Cell style={style} color='default' fontScale='p2'>{name}</Table.Cell>
Expand Down