Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] Allow webhook message to respond in thread #17863

Merged
merged 1 commit into from
Jun 19, 2020
Merged

[IMPROVE] Allow webhook message to respond in thread #17863

merged 1 commit into from
Jun 19, 2020

Conversation

Karting06
Copy link
Contributor

Proposed changes

At the moment, outgoing integrations can only respond in the form of a message (and not as an answer in a thread).
With this change, if a tmid is received, it will respond as an answer to a thread instead of a message.

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Adds ability to outgoing integration to respond in a thread.

Further comments

I don't know if tests are needed, and don't really know how to make them.

@ggazzo ggazzo merged commit bba4126 into RocketChat:develop Jun 19, 2020
@sampaiodiego sampaiodiego mentioned this pull request Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants