Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Hide system message add/remove owner #17938

Merged
merged 4 commits into from
Jun 18, 2020
Merged

[FIX] Hide system message add/remove owner #17938

merged 4 commits into from
Jun 18, 2020

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Jun 17, 2020 •
edited
Loading

closes #16772

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@ggazzo ggazzo added this to the 3.4.0 milestone Jun 17, 2020
@ggazzo ggazzo requested review from sampaiodiego and a team June 17, 2020 15:47
rodrigok
rodrigok requested changes Jun 17, 2020
View reviewed changes
server/startup/migrations/v193.js Outdated Show resolved Hide resolved
server/startup/migrations/v193.js Outdated Show resolved Hide resolved
ggazzo and others added 3 commits June 17, 2020 16:42
@ggazzo ggazzo requested a review from rodrigok June 17, 2020 22:51
@ggazzo ggazzo merged commit cf58d73 into develop Jun 18, 2020
@ggazzo ggazzo deleted the fix/hide-sys-mes branch June 18, 2020 14:27
gabriellsh added a commit that referenced this pull request Jun 18, 2020
@gabriellsh
Merge branch 'new/apps_rewrite' of github.com:RocketChat/Rocket.Chat …
e16b270 
…into new/apps_rewrite_local

* 'new/apps_rewrite' of github.com:RocketChat/Rocket.Chat:
  [FIX] Typo "coorosponding" (#17840)
  Regression: Infinite loop in CodeSettingInput (#17949)
  [NEW][ENTERPRISE] Download engagement data (#17920)
  [FIX] Hide system message add/remove owner  (#17938)
ggazzo added a commit that referenced this pull request Jun 18, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into feat…
1eb303a 
…/new-threads

* 'develop' of github.com:RocketChat/Rocket.Chat: (23 commits)
  [FIX] Typo "coorosponding" (#17840)
  Regression: Infinite loop in CodeSettingInput (#17949)
  [NEW][ENTERPRISE] Download engagement data (#17920)
  [FIX] Hide system message add/remove owner  (#17938)
  [IMPROVE] Performance editing Admin settings (#17916)
  [IMPROVE] React hooks lint rules (#17941)
  [FIX] StreamCast stream to server only streamers (#17942)
  [FIX] Profile save button not activates properly when changing the username field (#16541)
  [FIX] Outgoing webhook: Excessive spacing between trigger words (#17830)
  [FIX] Links being escaped twice leading to visible encoded characters (#16481)
  [NEW][API] New endpoints to manage User Custom Status `custom-user-status.create`, custom-user-status.delete` and `custom-user-status.update` (#16550)
  [FIX] Message action popup doesn't adjust itself on screen resize (#16508)
  [FIX] Not possible to translate the label of custom fields in user's Info (#15595)
  [FIX] Close the user info context panel does not navigate back to the user's list (#14085)
  [FIX] Missing pinned icon indicator for messages pinned (#16448)
  Chatpal: limit results to current room (#17718)
  Do not build Docker image for fork PRs (#17370)
  [IMPROVE] Use REST for DDP calls by default (#17934)
  [IMPROVE] Add rate limiter to UiKit endpoints (#17859)
  LingoHub based on develop (#17796)
  ...
@sampaiodiego sampaiodiego mentioned this pull request Jun 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigok rodrigok rodrigok approved these changes

@sampaiodiego sampaiodiego Awaiting requested review from sampaiodiego

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

Hide "Was Set Role" messages doesn't work
2 participants
@ggazzo @rodrigok