[FIX] Added explicit server oembed provider for Twitter #17954
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Use native oembed API for twitter in order to embed Tweets for direct links to Twitter posts
Issue(s)
#12924
How to test or reproduce
Paste a direct link to any tweet in any chat window in Rocket.Chat v3.3.3 and nothing happens. For example:
https://twitter.com/Pokemon/status/1273682732594475013
Screenshots
Instance without proposed fix:
Instance with the proposed fix:
Types of changes
Checklist
Changelog
Native Twitter oembed support for direct links to tweets
Further comments
Recommendedations for the future:
Also note that I have been unsuccessful in getting a Meteor environment set up on my machine, but I was able to test through manual changes to the bundle within Docker. Would be helpful if someone else could run linting / unit tests