Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Added explicit server oembed provider for Twitter #17954

Merged
merged 2 commits into from
Jun 19, 2020

Conversation

Cleod9
Copy link
Contributor

@Cleod9 Cleod9 commented Jun 18, 2020

Proposed changes

Use native oembed API for twitter in order to embed Tweets for direct links to Twitter posts

Issue(s)

#12924

How to test or reproduce

Paste a direct link to any tweet in any chat window in Rocket.Chat v3.3.3 and nothing happens. For example:
https://twitter.com/Pokemon/status/1273682732594475013

Screenshots

Instance without proposed fix:
image

Instance with the proposed fix:
image

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Native Twitter oembed support for direct links to tweets

Further comments

Recommendedations for the future:

  • Consider making oembed url patterns configurable in the Admin panel
  • Determine feasibility of embedding images and video

Also note that I have been unsuccessful in getting a Meteor environment set up on my machine, but I was able to test through manual changes to the bundle within Docker. Would be helpful if someone else could run linting / unit tests

@Cleod9 Cleod9 mentioned this pull request Jun 18, 2020
@engelgabriel engelgabriel added this to the 3.4.0 milestone Jun 18, 2020
@ggazzo ggazzo merged commit 79a30e8 into RocketChat:develop Jun 19, 2020
@sampaiodiego sampaiodiego mentioned this pull request Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants