Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Discussion not updating rooms list and not checking right permissions #17959

Merged
merged 3 commits into from
Jun 19, 2020

Conversation

sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Jun 19, 2020

Proposed changes

Validate if a user can send message on the channel he/she is trying to create the discussion.

Also update rooms list when a discussion is created.

Issue(s)

Closes #15430

How to test or reproduce

  • Mute an user on a room, with that user, create a discussion to that room
  • After creating a discussion check on other user's rooms list and the room will not be updated.

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@sampaiodiego sampaiodiego added this to the 3.4.0 milestone Jun 19, 2020
@sampaiodiego sampaiodiego requested a review from ggazzo June 19, 2020 06:05
@rodrigok rodrigok merged commit 8c91c42 into develop Jun 19, 2020
@rodrigok rodrigok deleted the fix-discussion-creation branch June 19, 2020 19:27
@sampaiodiego sampaiodiego mentioned this pull request Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No notification in parent channel on new discussions
2 participants