Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: App info broken #17979

Merged
merged 1 commit into from
Jun 21, 2020
Merged

Regression: App info broken #17979

merged 1 commit into from
Jun 21, 2020

Conversation

shiqimei
Copy link
Contributor

@shiqimei shiqimei commented Jun 20, 2020

Proposed changes

Some APIs failed to show in the app details page. Add Promise.all to make sure all promises could be resolved before return the data.

Issue(s)

n/a

How to test or reproduce

Screenshots

  1. Create an example app that registered a webhook URL, deploy it to the dev server.
  2. Go to admin - apps - apps detail, check if APIs section is missing.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@ggazzo ggazzo changed the title Fix APIs missing Regression: App info broken Jun 21, 2020
@ggazzo ggazzo merged commit 9ee519b into develop Jun 21, 2020
@ggazzo ggazzo deleted the apps.client.fix-apis-missing branch June 21, 2020 02:16
@sampaiodiego sampaiodiego mentioned this pull request Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants