Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Only add reply-to if sender has emails #17998

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

sampaiodiego
Copy link
Member

Proposed changes

E-mail notifications were broken for livechat when using Manual Selection routing method because the sender is the visitor in this context and it has no email addresses.

Issue(s)

How to test or reproduce

  • Set livechat routing method to Manual Selection
  • Start a new livechat

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@sampaiodiego sampaiodiego added this to the 3.4.0 milestone Jun 22, 2020
@sampaiodiego sampaiodiego merged commit ca4dfa6 into develop Jun 22, 2020
@sampaiodiego sampaiodiego deleted the fix-email-notification-sender-without-emails branch June 22, 2020 13:01
@sampaiodiego sampaiodiego mentioned this pull request Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants