Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] User is prompted to reset their password when logging with OAuth #18001

Merged
merged 1 commit into from
Jun 22, 2020
Merged

[FIX] User is prompted to reset their password when logging with OAuth #18001

merged 1 commit into from
Jun 22, 2020

Conversation

pierre-lehnen-rc
Copy link
Contributor

When the 'Verify Email for External Accounts' setting is turned off, OAuth users are being asked to change their passwords.

Proposed changes

Issue(s)

Closes #18000

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@pierre-lehnen-rc pierre-lehnen-rc changed the title [FIX] User is prompted to reset their password when logging in with O… [FIX] User is prompted to reset their password when logging with OAuth Jun 22, 2020
@pierre-lehnen-rc pierre-lehnen-rc added this to the 3.4.0 milestone Jun 22, 2020
@sampaiodiego sampaiodiego merged commit 2dde4fd into develop Jun 22, 2020
@sampaiodiego sampaiodiego deleted the fix.18000 branch June 22, 2020 17:13
gabriellsh added a commit that referenced this pull request Jun 22, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into fix/…
c3852b6 
…prune_discussions

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Remove useLazyRef hook usage (#18003)
  [FIX] User is prompted to reset their password when logging in with OAuth provider (#18001)
  [FIX] Missing i18n key for setting: Verify Email for External Accounts (#18002)
  Regression: Cannot save avatar change on admin (#17999)
  [NEW][ENTERPRISE] Omnichannel multiple business hours (#17947)
  [FIX] New Omnichannel Past Chats list padding (#17994)
@sampaiodiego sampaiodiego mentioned this pull request Jun 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

@rodrigok rodrigok Awaiting requested review from rodrigok

Assignees

@rodrigok rodrigok

Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

User is prompted to reset their password when logging in with OAuth provider
3 participants
@pierre-lehnen-rc @sampaiodiego @rodrigok