Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: Fix threads badge color indicators #18048

Merged
merged 3 commits into from
Jun 28, 2020
Merged

Regression: Fix threads badge color indicators #18048

merged 3 commits into from
Jun 28, 2020

Conversation

sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Jun 25, 2020 •
edited
Loading

Proposed changes

Implement badge colors for threads.

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@sampaiodiego sampaiodiego added this to the 3.4.0 milestone Jun 25, 2020
@sampaiodiego sampaiodiego requested a review from ggazzo June 25, 2020 18:16
@rodrigok rodrigok merged commit 6f3fc56 into develop Jun 28, 2020
@rodrigok rodrigok deleted the fix-threads-indicators branch June 28, 2020 14:53
gabriellsh added a commit that referenced this pull request Jun 30, 2020
@gabriellsh
Merge branch 'new/account_sidebar_rewrite' of github.com:RocketChat/R…
7de66a7 
…ocket.Chat into new/rewrite_account_profile

* 'new/account_sidebar_rewrite' of github.com:RocketChat/Rocket.Chat:
  Fix sidenav close
  Regresion: Issue with reply button on broadcast channels (#18057)
  Regression: Infinite render loop on Setup Wizard (#18074)
  Regression: Improve Omnichannel Business Hours (#18050)
  Regression: Fix threads badge color indicators (#18048)
  Regression: Improve the logic to get request IPs (#18033)
@sampaiodiego sampaiodiego mentioned this pull request Jun 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigok rodrigok rodrigok approved these changes

@ggazzo ggazzo Awaiting requested review from ggazzo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sampaiodiego @rodrigok @ggazzo