Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] Change setting that blocks unauthenticated access to avatar to public #18316

Merged
merged 3 commits into from
Jul 21, 2020
Merged

[IMPROVE] Change setting that blocks unauthenticated access to avatar to public #18316

merged 3 commits into from
Jul 21, 2020

Conversation

djorkaeffalexandre
Copy link
Contributor

…ting

Proposed changes

Clients can get this setting and know if should send the authorization params or not.

Issue(s)

How to test or reproduce

Try to get the public settings and see if it's listed.

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Turn Accounts_AvatarBlockUnauthenticatedAccess a public setting, so, the clients can know if should send the authorization params or not.

Further comments

@sampaiodiego sampaiodiego changed the title [IMPROVE] Turn Accounts_AvatarBlockUnauthenticatedAccess a public setting [IMPROVE] Change setting that blocks unauthenticated access to avatar to public Jul 21, 2020
@sampaiodiego sampaiodiego added this to the 3.5.0 milestone Jul 21, 2020
@sampaiodiego sampaiodiego merged commit 523e754 into RocketChat:develop Jul 21, 2020
@sampaiodiego sampaiodiego mentioned this pull request Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants