Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Bug on entering token in connectivity services #18317

Merged
merged 3 commits into from
Jul 21, 2020

Conversation

geekgonecrazy
Copy link
Contributor

@geekgonecrazy geekgonecrazy commented Jul 20, 2020

Proposed changes

Removes getting access token from connect. Something server side caused it to be returned too soon. It would try and get a token before it had valid creds. Which in some cases caused a workspace to both register and then unregister at the same time.

Also improved wording with simplified registration process.

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@geekgonecrazy geekgonecrazy modified the milestones: 3.4.3, 3.5.0 Jul 20, 2020
@ggazzo ggazzo merged commit 47d1438 into develop Jul 21, 2020
@ggazzo ggazzo deleted the fix-connectivity-services-registration branch July 21, 2020 04:23
@sampaiodiego sampaiodiego mentioned this pull request Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants