Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Provide a fallback text when push notification is idOnly #18373

Merged
merged 2 commits into from
Jul 25, 2020
Merged

Regression: Provide a fallback text when push notification is idOnly #18373

merged 2 commits into from
Jul 25, 2020

Conversation

djorkaeffalexandre
Copy link
Contributor

Proposed changes

How to test or reproduce

  1. Get the latest iOS beta (internal testers).
  2. Enable fetch content from server on Push notification Privacy.
  3. Send a notification and put your server down.
  4. It will show the fallback message. (Someone send you a message)

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Provide a fallback text when push notification is idOnly and can't be fetched.

Further comments

@sampaiodiego sampaiodiego changed the title [IMPROVE] Provide a fallback text when push notification is idOnly Regression: Provide a fallback text when push notification is idOnly Jul 24, 2020
@sampaiodiego sampaiodiego merged commit cf05327 into RocketChat:develop Jul 25, 2020
@sampaiodiego sampaiodiego mentioned this pull request Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants