Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Treating loading on the audio message done #21082

Closed
wants to merge 3 commits into from
Closed

[FIX] Treating loading on the audio message done #21082

wants to merge 3 commits into from

Conversation

matheus-rn
Copy link

@matheus-rn matheus-rn commented Mar 11, 2021 •
edited by dougfabris
Loading

  • I have read the Contributing Guide.
  • I have signed the CLA.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • Any dependent changes have been merged and published in downstream modules
  • I have added necessary documentation (if applicable)

Proposed changes

Avoid problem infinite loading in the audio message

image

Issue(s)

Closes #21078

matheus-rn and others added 3 commits March 11, 2021 14:42
@matheus-rn @gdeusdara
[FIX] Treating loading on the audio message done (RocketChat#21078)
0e34e29 
Signed-off-by: matheus rodrigues <matheus.1nascimento58@gmail.com>
Co-authored-by: Guilherme Banci <guibanci@gmail.com>
@matheus-rn @gdeusdara
Chore stop record
240e7cd 
Signed-off-by: matheus rodrigues <matheus.1nascimento58@gmail.com>
Co-authored-by: Guilherme Banci <guibanci@gmail.com>
@matheus-rn
Merge branch 'develop' into fix/confirm-audio
e2f3c34
@yash-rajpal yash-rajpal mentioned this pull request Mar 19, 2021
Closed
@matheus-rn matheus-rn mentioned this pull request Mar 24, 2021
Closed
@CLAassistant
Copy link

CLAassistant commented Dec 17, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@dougfabris
Copy link
Member

@matheus-rn Recently we refactor our Message Composer and it already fixes it! #27566
Because of that, I'm closing this one, thank you so much for your help!

@dougfabris dougfabris closed this Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
communityPR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Infinite loading when clicking confirm audio, before allowing the microphone to be used
4 participants
@matheus-rn @CLAassistant @dougfabris @debdutdeb