Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Livechat-jitsi-call #22678

Closed
wants to merge 1 commit into from
Closed

[FIX] Livechat-jitsi-call #22678

wants to merge 1 commit into from

Conversation

Deepak-learner
Copy link
Contributor

Current if you make get request http://localhost:3000/api/v1/livechat/video.call/: token with Livechat.videoCall() at widget side, it was showing bad request because there was some error at rc-core server file. But after doing changes at rc-core server side and making an api call with Livechat.videoCall , now I am getting the expected result at widget side as shown in the image below.
Screenshot 2021-07-15 at 1 19 11 PM

@@ -33,9 +32,6 @@ API.v1.addRoute('livechat/video.call/:token', {
throw new Meteor.Error('invalid-livechat-config');
}

Messages.createWithTypeRoomIdMessageAndUser('livechat_video_call', room._id, '', guest, {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are removing this message creation function, then how will the agent know whether a jitsi call is initiated or not.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And also are you allowing visitor to initiate Jitsi call?

Copy link
Contributor Author

@Deepak-learner Deepak-learner Jul 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you click on phone icon button, the agent will be redirected to new tab or the call will start on same tab depend on jitsi configuration done by administrator. The function I remove is responsible for join call button action that will appear in chat. I agree current solution is not correct solution, as by remove this function will remove the functionality of join call button which can be use in case agent by mistake close the call window. So I am working on that. But I think the error is in this function Messages.createWithTypeRoomIdMessageAndUser only because as I remove this function api is working fine. I am able to get responses as shown in the above image at widget side.

No, I am not allowing visitors to initiate the call. Above response I got from api after the visitor clicks on the accept button at widget side and then response will be used for generating a link for jitsi at widget side.

@Deepak-learner Deepak-learner marked this pull request as draft July 16, 2021 18:00
@murtaza98 murtaza98 self-requested a review July 18, 2021 06:01
@murtaza98 murtaza98 force-pushed the livechat-calls branch 2 times, most recently from a272f80 to 8085535 Compare November 22, 2021 08:44
@murtaza98 murtaza98 deleted the branch RocketChat:livechat-calls November 22, 2021 15:14
@murtaza98 murtaza98 closed this Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants