Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] Re-naming department query param for Twilio #23725

Merged
merged 1 commit into from
Nov 17, 2021
Merged

[IMPROVE] Re-naming department query param for Twilio #23725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/livechat/imports/server/rest/sms.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ API.v1.addRoute('livechat/sms-incoming/:service', {
post() {
const SMSService = SMS.getService(this.urlParams.service);
const sms = SMSService.parse(this.bodyParams);
const { departmentName } = this.queryParams;
let targetDepartment = defineDepartment(departmentName || SMS.department);
const { department } = this.queryParams;
let targetDepartment = defineDepartment(department || SMS.department);
if (!targetDepartment) {
targetDepartment = defineDepartment(SMS.department);
}
Expand Down
2 changes: 1 addition & 1 deletion packages/rocketchat-i18n/i18n/en.i18n.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3911,7 +3911,7 @@
"Smileys_and_People": "Smileys & People",
"SMS": "SMS",
"SMS_Default_Omnichannel_Department": "Omnichannel Department (Default)",
"SMS_Default_Omnichannel_Department_Description": "If set, all new incoming chats initiated by this integration will be routed to this department.\nThis setting can be overwritten by passing departmentName query param in the request.\ne.g. https://<SERVER_URL>/api/v1/livechat/sms-incoming/twilio?departmentName=< departmentName>.\nDepartment name should be URL safe.",
"SMS_Default_Omnichannel_Department_Description": "If set, all new incoming chats initiated by this integration will be routed to this department.\nThis setting can be overwritten by passing department query param in the request.\ne.g. https://<SERVER_URL>/api/v1/livechat/sms-incoming/twilio?department=<Department Id or Name>.\nNote: if you're using Department Name, then it should be URL safe.",
"SMS_Enabled": "SMS Enabled",
"SMTP": "SMTP",
"SMTP_Host": "SMTP Host",
Expand Down