-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Change Omnichannel aggregations to run on a secondary #25346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you, Kevin! |
I think there are a few conflicts to solve 🙈 |
C'mon, just like 1 or 2 lines of conflicts. EZ |
KevLehman
force-pushed
the
chore/make-aggs-run-on-secondary
branch
from
November 9, 2022 02:08
59244c8
to
202dfad
Compare
Codecov Report
@@ Coverage Diff @@
## develop #25346 +/- ##
===========================================
+ Coverage 41.13% 42.15% +1.02%
===========================================
Files 846 819 -27
Lines 18378 17859 -519
Branches 2101 2026 -75
===========================================
- Hits 7560 7529 -31
+ Misses 10534 10047 -487
+ Partials 284 283 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
@sampaiodiego , you can do your magic with the review now |
sampaiodiego
changed the title
Chore: Change aggregations to run on secondary
Chore: Change Omnichannel aggregations to run on a secondary
Dec 7, 2022
sampaiodiego
approved these changes
Dec 7, 2022
dionisio-bot
bot
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: needs QA
labels
Dec 7, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments