Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Change Omnichannel aggregations to run on a secondary #25346

Merged
merged 2 commits into from
Dec 7, 2022

Conversation

KevLehman
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@KevLehman KevLehman requested a review from a team April 29, 2022 19:20
@ankar84
Copy link

ankar84 commented Apr 30, 2022

Thank you, Kevin!

@ggazzo ggazzo requested a review from a team May 4, 2022 18:08
@sampaiodiego
Copy link
Member

I think there are a few conflicts to solve 🙈

@KevLehman
Copy link
Contributor Author

I think there are a few conflicts to solve 🙈

C'mon, just like 1 or 2 lines of conflicts. EZ

@KevLehman KevLehman force-pushed the chore/make-aggs-run-on-secondary branch from 59244c8 to 202dfad Compare November 9, 2022 02:08
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #25346 (00af432) into develop (557708a) will increase coverage by 1.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #25346      +/-   ##
===========================================
+ Coverage    41.13%   42.15%   +1.02%     
===========================================
  Files          846      819      -27     
  Lines        18378    17859     -519     
  Branches      2101     2026      -75     
===========================================
- Hits          7560     7529      -31     
+ Misses       10534    10047     -487     
+ Partials       284      283       -1     
Flag Coverage Δ
e2e 42.15% <ø> (+1.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman
Copy link
Contributor Author

@sampaiodiego , you can do your magic with the review now :trollface:

@ggazzo ggazzo added this to the 6.0.0-pre milestone Nov 24, 2022
@sampaiodiego sampaiodiego changed the title Chore: Change aggregations to run on secondary Chore: Change Omnichannel aggregations to run on a secondary Dec 7, 2022
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Dec 7, 2022
@kodiakhq kodiakhq bot merged commit 45415c3 into develop Dec 7, 2022
@kodiakhq kodiakhq bot deleted the chore/make-aggs-run-on-secondary branch December 7, 2022 13:21
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eng day stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants