-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Change bundle tags color and refactor app details page header styles #27293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increased the rightside margin of the app avatar, removed the 'by' substring from the app author metadata and changed the fontScale and colors for the metadata section and short description.
rique223
changed the title
Chore: Refactor app details page header styles
Chore: Change bundle tags color and refactor app details page header styles
Nov 17, 2022
Codecov Report
@@ Coverage Diff @@
## develop #27293 +/- ##
===========================================
+ Coverage 41.99% 42.93% +0.93%
===========================================
Files 844 817 -27
Lines 17751 17234 -517
Branches 2009 1934 -75
===========================================
- Hits 7455 7399 -56
+ Misses 10032 9572 -460
+ Partials 264 263 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
dougfabris
requested changes
Jan 10, 2023
…m:RocketChat/Rocket.Chat into chore/app-metadata-typography-marketplace
juliajforesti
requested changes
Jan 10, 2023
apps/meteor/client/views/admin/apps/AppDetailsPage/AppDetailsPageHeader.tsx
Outdated
Show resolved
Hide resolved
…m:RocketChat/Rocket.Chat into chore/app-metadata-typography-marketplace
juliajforesti
previously approved these changes
Jan 13, 2023
dougfabris
requested changes
Jan 13, 2023
apps/meteor/client/views/admin/apps/AppDetailsPage/AppDetailsPageHeader.tsx
Outdated
Show resolved
Hide resolved
dougfabris
requested changes
Jan 13, 2023
apps/meteor/client/views/admin/apps/AppDetailsPage/AppDetailsPageHeader.tsx
Outdated
Show resolved
Hide resolved
…m:RocketChat/Rocket.Chat into chore/app-metadata-typography-marketplace
dougfabris
approved these changes
Jan 13, 2023
dionisio-bot
bot
added
the
stat: ready to merge
PR tested and approved waiting for merge
label
Jan 16, 2023
gabriellsh
added a commit
that referenced
this pull request
Jan 16, 2023
…ixSearch * 'develop' of github.com:RocketChat/Rocket.Chat: Chore: Show different labels based on the call originator on direct calls (#27729) Chore: Change bundle tags color and refactor app details page header styles (#27293) [FIX] Auto Translate not working on new message template (#27317) Chore: Custom Sounds Empty State (#27632) [IMPROVE] Require acceptance when setting new E2E Encryption key for another user (#27556) Regression: Broken room and message composer events (#27754) [FIX] Missing placeholders from encrypted channel preview messages now with expected behavior (#27699) [IMPROVE] SAML and OAuth role sync to support id and name (#27405) Chore: add e2e test coverage for Video Conference (#27075) Chore: Invites Empty State (#27631) [FIX] Marketplace app status initially disabled (#27330) Regression: Missing contexts on contextual bar (#27734)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Increased the right side margin of the app avatar, removed the 'by' substring from the app author metadata, and changed the font scale and colors for the metadata section and short description.
Demo image:
Issue(s)
Steps to test or reproduce
Further comments