Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Change bundle tags color and refactor app details page header styles #27293

Merged
merged 25 commits into from
Jan 16, 2023

Conversation

rique223
Copy link
Contributor

Proposed changes (including videos or screenshots)

Increased the right side margin of the app avatar, removed the 'by' substring from the app author metadata, and changed the font scale and colors for the metadata section and short description.
Demo image:
image

Issue(s)

Steps to test or reproduce

Further comments

Increased the rightside margin of the app avatar, removed the 'by' substring from the app author metadata and changed the fontScale and colors for the metadata section and short description.
@rique223 rique223 changed the title Chore: Refactor app details page header styles Chore: Change bundle tags color and refactor app details page header styles Nov 17, 2022
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #27293 (5189862) into develop (c420e99) will increase coverage by 0.93%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27293      +/-   ##
===========================================
+ Coverage    41.99%   42.93%   +0.93%     
===========================================
  Files          844      817      -27     
  Lines        17751    17234     -517     
  Branches      2009     1934      -75     
===========================================
- Hits          7455     7399      -56     
+ Misses       10032     9572     -460     
+ Partials       264      263       -1     
Flag Coverage Δ
e2e 42.93% <ø> (+0.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rique223 rique223 marked this pull request as ready for review January 9, 2023 13:30
@rique223 rique223 requested a review from a team as a code owner January 9, 2023 13:30
@rique223 rique223 requested a review from dougfabris January 10, 2023 18:57
juliajforesti
juliajforesti previously approved these changes Jan 13, 2023
@rique223 rique223 requested a review from dougfabris January 13, 2023 16:45
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 16, 2023
@kodiakhq kodiakhq bot merged commit cf8e44c into develop Jan 16, 2023
@kodiakhq kodiakhq bot deleted the chore/app-metadata-typography-marketplace branch January 16, 2023 20:40
gabriellsh added a commit that referenced this pull request Jan 16, 2023
…ixSearch

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Chore: Show different labels based on the call originator on direct calls (#27729)
  Chore: Change bundle tags color and refactor app details page header styles (#27293)
  [FIX] Auto Translate not working on new message template (#27317)
  Chore: Custom Sounds Empty State (#27632)
  [IMPROVE] Require acceptance when setting new E2E Encryption key for another user (#27556)
  Regression: Broken room and message composer events (#27754)
  [FIX] Missing placeholders from encrypted channel preview messages now with expected behavior (#27699)
  [IMPROVE] SAML and OAuth role sync to support id and name (#27405)
  Chore: add e2e test coverage for Video Conference (#27075)
  Chore: Invites Empty State (#27631)
  [FIX] Marketplace app status initially disabled (#27330)
  Regression: Missing contexts on contextual bar (#27734)
gabriellsh added a commit that referenced this pull request Jan 17, 2023
* matrixSearch:
  First iteration
  Chore: Show different labels based on the call originator on direct calls (#27729)
  Chore: Change bundle tags color and refactor app details page header styles (#27293)
  [FIX] Auto Translate not working on new message template (#27317)
 the commit.
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: apps ecosystem AECO stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants