Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update tsconfig base target to es2020 #27552

Merged
merged 21 commits into from
Dec 26, 2022
Merged

Conversation

sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Dec 15, 2022

Proposed changes (including videos or screenshots)

The base files are not split into two other files, a "client" and a "server" file. Both extends the new base one. Packages should extend either "client" or "server" ones:

graph TD;
    base[tsconfig.base.json]-->client[tsconfig.base.client.json];
    base-->server[tsconfig.base.server.json];
    server-->s1["@rocket.chat/models"];
    server-->s2["@rocket.chat/ddp-streamer"];
    server-->s3[...];
    client-->c1["@rocket.chat/ui-theming"];
    client-->c2["@rocket.chat/fuselage-ui-kit"];
    client-->c3[...];
Loading

Important changes:

  • The client config target have been bumped to es2015 (it was es5 before)
  • The server config target have been bumped to es2020
  • The default value for jsx is react-jsx
  • Raised "noUnusedLocals": true to a base config, so had to remove a bunch of imports to React that were not being used

Issue(s)

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #27552 (4a5d0af) into develop (61689c8) will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27552      +/-   ##
===========================================
- Coverage    43.78%   43.65%   -0.14%     
===========================================
  Files          812      812              
  Lines        17176    17176              
  Branches      1902     1902              
===========================================
- Hits          7521     7498      -23     
- Misses        9402     9425      +23     
  Partials       253      253              
Flag Coverage Δ
e2e 43.65% <ø> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@sampaiodiego sampaiodiego marked this pull request as ready for review December 19, 2022 18:09
@sampaiodiego sampaiodiego requested review from a team as code owners December 19, 2022 18:09
Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create a client base, sever base and base base :)

@sampaiodiego sampaiodiego requested a review from ggazzo December 23, 2022 14:58
@ggazzo ggazzo merged commit 4f2895a into develop Dec 26, 2022
@ggazzo ggazzo deleted the update-tsconfigbase branch December 26, 2022 15:42
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants