-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] PDF Worker service #27568
Merged
Merged
[NEW] PDF Worker service #27568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevLehman
commented
Dec 16, 2022
Codecov Report
@@ Coverage Diff @@
## feat/chat-transcript #27568 +/- ##
========================================================
- Coverage 43.04% 42.91% -0.13%
========================================================
Files 818 818
Lines 17267 17267
Branches 1944 1944
========================================================
- Hits 7432 7410 -22
- Misses 9569 9593 +24
+ Partials 266 264 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
KevLehman
force-pushed
the
new/queue-service-base
branch
from
December 20, 2022 01:26
eef7485
to
f9441a0
Compare
KevLehman
force-pushed
the
new/pdf-worker-base
branch
from
December 20, 2022 01:32
2cf1815
to
4b4d2a4
Compare
Base automatically changed from
new/queue-service-base
to
feat/chat-transcript
December 22, 2022 16:17
murtaza98
reviewed
Dec 23, 2022
murtaza98
reviewed
Dec 23, 2022
apps/meteor/ee/app/livechat-enterprise/server/api/transcript.ts
Outdated
Show resolved
Hide resolved
murtaza98
reviewed
Dec 23, 2022
murtaza98
previously requested changes
Dec 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KevLehman FYI: Left a few comments here. Overall it looks great! 🎉
murtaza98
reviewed
Dec 26, 2022
murtaza98
reviewed
Dec 26, 2022
murtaza98
reviewed
Dec 26, 2022
murtaza98
reviewed
Dec 26, 2022
murtaza98
reviewed
Dec 26, 2022
* new: add header component and load fonts * feat: add pagination * chore: add line height * chore: move date and time to template function * chore: move component dir and replace dateFormat * chroe: add request to export pdf button * feat: add divider and pass dateAndTime format to pdf woker * chore: add storybook * chore: move divider * chore: remove duplicated style
murtaza98
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
OC-500