Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Black screen when try to open a chat with a non-existent department #27609

Merged
merged 15 commits into from
Feb 7, 2023

Conversation

murtaza98
Copy link
Contributor

@murtaza98 murtaza98 commented Dec 22, 2022

Proposed changes (including videos or screenshots)

Issue(s)

OC-427

Steps to test or reproduce

Further comments

@murtaza98 murtaza98 requested a review from a team as a code owner December 22, 2022 08:09
@murtaza98 murtaza98 changed the title [FIX] Black screen when try to open a chat with a non-existent depart… [FIX] Black screen when try to open a chat with a non-existent department Dec 22, 2022
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #27609 (179449b) into develop (4271efd) will increase coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #27609   +/-   ##
========================================
  Coverage    41.46%   41.47%           
========================================
  Files          841      841           
  Lines        17701    17697    -4     
  Branches      1996     1996           
========================================
  Hits          7339     7339           
+ Misses       10119    10115    -4     
  Partials       243      243           
Flag Coverage Δ
e2e 41.47% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

KevLehman
KevLehman previously approved these changes Dec 23, 2022
@murtaza98 murtaza98 dismissed stale reviews from KevLehman and aleksandernsilva via ecff71a December 27, 2022 07:40
@murtaza98 murtaza98 requested a review from a team as a code owner December 27, 2022 07:40
@murtaza98 murtaza98 requested a review from a team as a code owner December 27, 2022 10:32
KevLehman
KevLehman previously approved these changes Dec 27, 2022
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jan 4, 2023
@murtaza98 murtaza98 added this to the 6.0.0 milestone Jan 4, 2023
@murtaza98
Copy link
Contributor Author

Hi @RocketChat/chat-engine, Just a quick reminder - this PR is waiting for review. If you have a sec, can you check it out and let us know what you think? Thanks in advance 🤗

@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Jan 9, 2023
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Jan 9, 2023

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@rodrigok rodrigok merged commit 2b210a9 into develop Feb 7, 2023
@rodrigok rodrigok deleted the omni/deleted-department-blank-screen branch February 7, 2023 19:01
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: omnichannel stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants