[NEW] Create page for "No private apps installed" #27708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagoevanp
requested changes
Jan 23, 2023
…hat into feat/create-EmptyPrivateApps-page
…Chat/Rocket.Chat into feat/create-EmptyPrivateApps-page
Codecov Report
@@ Coverage Diff @@
## feat/new-marketplace #27708 +/- ##
========================================================
- Coverage 43.18% 43.11% -0.08%
========================================================
Files 821 823 +2
Lines 17041 17053 +12
Branches 2004 2004
========================================================
- Hits 7359 7352 -7
- Misses 9402 9423 +21
+ Partials 280 278 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
…hat into feat/create-EmptyPrivateApps-page
tiagoevanp
added a commit
that referenced
this pull request
Feb 12, 2023
* create component for "No private apps installed" * fix review * review 2 --------- Co-authored-by: Tiago Evangelista Pinto <tiago.evangelista@rocket.chat>
tiagoevanp
added a commit
that referenced
this pull request
Feb 13, 2023
* create EnabledAppsCount * fix component * create new MarketplaceHeader component * fix review * fix fuselage up version * fix review * better collors suggestion * fix permission * Revert "better collors suggestion" This reverts commit 31479c3. * enterprise license check * add upsell modal * add context for number of apps (work in progress) * update progressbar from fuselage * use apps context [wip] * private limits vs marketplace limits * Remove app dev mode setting * Use new app count endpoint * remove new permission * Add tooltip to enabled count component * Remove useMemo and adapt tooltip * Use correct context on tooltip * use numbers * use title * [NEW] Create page for "No private apps installed" (#27708) * create component for "No private apps installed" * fix review * review 2 --------- Co-authored-by: Tiago Evangelista Pinto <tiago.evangelista@rocket.chat> * chore: remove title for all no explore context * remove unnecessary useMemo * useQuery instead of calling useEndpoint * Fix translation keys * Fix lint * Update apps/meteor/ee/app/license/server/bundles.ts * Update apps/meteor/ee/app/license/server/bundles.ts * Apply suggestions from code review * Review * remove pooling * code tweak --------- Co-authored-by: Tiago Evangelista Pinto <tiago.evangelista@rocket.chat> Co-authored-by: Douglas Gubert <douglas.gubert@gmail.com> Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Created a new component
apps/meteor/client/components/PageEmptyPrivateApps.tsxfor the "No private apps installed" page.Issue(s)
Steps to test or reproduce
Further comments
MKP-217