-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Create EnterpriseTrialEnded
banner
#27731
Merged
tiagoevanp
merged 15 commits into
feat/new-marketplace
from
feat/create-banner-EnterpriseTrialEnded
Feb 12, 2023
Merged
[NEW] Create EnterpriseTrialEnded
banner
#27731
tiagoevanp
merged 15 commits into
feat/new-marketplace
from
feat/create-banner-EnterpriseTrialEnded
Feb 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagoevanp
changed the title
[NEW] Create EnterpriseTrialEnded banner
[NEW] Create Jan 24, 2023
EnterpriseTrialEnded
banner
…hat into feat/create-banner-EnterpriseTrialEnded
Codecov Report
@@ Coverage Diff @@
## feat/new-marketplace #27731 +/- ##
========================================================
- Coverage 43.18% 42.62% -0.57%
========================================================
Files 821 823 +2
Lines 17041 17036 -5
Branches 2004 2012 +8
========================================================
- Hits 7359 7261 -98
- Misses 9402 9499 +97
+ Partials 280 276 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
…hat into feat/create-banner-EnterpriseTrialEnded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Create new banner component
apps/meteor/client/components/BannerEnterpriseTrialEnded.tsx
with two variants, depending on admin role:Issue(s)
Steps to test or reproduce
Further comments
Translation still needs to be corrected.
MKP-219