Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Create EnterpriseTrialEnded banner #27731

Merged

Conversation

felipe-rod123
Copy link
Contributor

@felipe-rod123 felipe-rod123 commented Jan 11, 2023

Proposed changes (including videos or screenshots)

Create new banner component apps/meteor/client/components/BannerEnterpriseTrialEnded.tsx with two variants, depending on admin role:

non-admin
admin

Issue(s)

Steps to test or reproduce

Further comments

Translation still needs to be corrected.
MKP-219

@felipe-rod123 felipe-rod123 requested a review from a team January 11, 2023 21:55
@felipe-rod123 felipe-rod123 marked this pull request as ready for review January 12, 2023 23:35
@felipe-rod123 felipe-rod123 requested a review from a team as a code owner January 12, 2023 23:35
@tiagoevanp tiagoevanp changed the base branch from develop to feat/new-marketplace January 24, 2023 12:18
@tiagoevanp tiagoevanp changed the title [NEW] Create EnterpriseTrialEnded banner [NEW] Create EnterpriseTrialEnded banner Jan 24, 2023
@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Merging #27731 (4c8c23a) into feat/new-marketplace (ca49a7f) will decrease coverage by 0.57%.
The diff coverage is 67.34%.

Impacted file tree graph

@@                   Coverage Diff                    @@
##           feat/new-marketplace   #27731      +/-   ##
========================================================
- Coverage                 43.18%   42.62%   -0.57%     
========================================================
  Files                       821      823       +2     
  Lines                     17041    17036       -5     
  Branches                   2004     2012       +8     
========================================================
- Hits                       7359     7261      -98     
- Misses                     9402     9499      +97     
+ Partials                    280      276       -4     
Flag Coverage Δ
e2e 42.62% <67.34%> (-0.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tiagoevanp tiagoevanp merged commit 6e6cac2 into feat/new-marketplace Feb 12, 2023
@tiagoevanp tiagoevanp deleted the feat/create-banner-EnterpriseTrialEnded branch February 12, 2023 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants