-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAK] Move Multiple Department Creation to EE & [NEW] Department Archive #27753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #27753 +/- ##
===========================================
+ Coverage 41.52% 42.46% +0.93%
===========================================
Files 833 803 -30
Lines 17125 16563 -562
Branches 2068 1998 -70
===========================================
- Hits 7112 7033 -79
+ Misses 9742 9256 -486
- Partials 271 274 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
aleksandernsilva
requested changes
Jan 16, 2023
apps/meteor/client/components/Omnichannel/modals/EnterpriseDepartmentsModal.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/components/Omnichannel/modals/EnterpriseDepartmentsModal.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/components/Omnichannel/modals/EnterpriseDepartmentsModal.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/omnichannel/departments/NewDepartment.tsx
Outdated
Show resolved
Hide resolved
…at/Rocket.Chat into move-save-department-ee
tassoevan
requested changes
Jan 16, 2023
tassoevan
requested changes
Jan 16, 2023
aleksandernsilva
requested changes
Jan 16, 2023
apps/meteor/client/views/omnichannel/departments/NewDepartment.tsx
Outdated
Show resolved
Hide resolved
aleksandernsilva
previously approved these changes
Jan 18, 2023
aleksandernsilva
previously approved these changes
Feb 10, 2023
tassoevan
dismissed stale reviews from aleksandernsilva, sampaiodiego, and KevLehman
via
February 11, 2023 20:18
679c67f
tassoevan
previously approved these changes
Feb 12, 2023
aleksandernsilva
requested changes
Feb 13, 2023
apps/meteor/client/views/omnichannel/departments/ArchivedItemMenu.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/omnichannel/departments/NewDepartment.tsx
Outdated
Show resolved
Hide resolved
tassoevan
approved these changes
Feb 13, 2023
aleksandernsilva
approved these changes
Feb 13, 2023
KevLehman
approved these changes
Feb 13, 2023
dionisio-bot
bot
added
the
stat: ready to merge
PR tested and approved waiting for merge
label
Feb 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
[BREAK] Move Multiple Department Creation to EE: Limit max department creation to 1 in Community edition, existing departments will still function as before.
[NEW] 📁 Department archival: Adds the ability to archive departments, archived departments are disabled and cannot be edited, but will still show in historical data (current chats, directory, chat info, etc...). This offers an alternative to department deletion.
OC-542
OC-543
OC-609
OC-610
OC-611
OC-659