[FIX] App page showing version undefined for apps not in marketplace #27766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-gubert
changed the title
tiagoevanp
approved these changes
Jan 16, 2023
dionisio-bot
bot
added
stat: ready to merge
Codecov Report
@@ Coverage Diff @@
## develop #27766 +/- ##
===========================================
+ Coverage 41.89% 42.93% +1.03%
===========================================
Files 844 817 -27
Lines 17751 17234 -517
Branches 2009 1934 -75
===========================================
- Hits 7437 7399 -38
+ Misses 10052 9571 -481
- Partials 262 264 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
gabriellsh
added a commit
that referenced
this pull request
Jan 23, 2023
…etChat/Rocket.Chat into matrixSearch * 'feat/federation-search-public-rooms' of github.com:RocketChat/Rocket.Chat: Chore: Move service shutdown logic to each service (#27690) Chore: change colors to dark theme on Marketplace (#27532) Chore: Update color tokens (#27704) Chore: Remove medium prop from ButtonGroup (#27784) Regression: Add support for 2FA errors to `Meteor.callAsync` (#27767) [NEW] Attachment Files Redesign (#27470) [FIX] App page showing version undefined for apps not in marketplace (#27766) Chore: Add surface-light background to AppRow (#27765)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The app page is not showing the correct version of apps that are installed in the workspace but not in the Marketplace.
This PR changes the behavior so that the page shows the version that is installed in the workspace; otherwise, it shows the version in the marketplace
Issue(s)
Steps to test or reproduce
Further comments