Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Create generic upsell modal component #27769

Merged
merged 4 commits into from
Jan 20, 2023

Conversation

felipe-rod123
Copy link
Contributor

@felipe-rod123 felipe-rod123 commented Jan 16, 2023

Proposed changes (including videos or screenshots)

Created the reuseable upsell modal component

Issue(s)

Steps to test or reproduce

Further comments

@felipe-rod123 felipe-rod123 force-pushed the feat/create-generic-upsell-modal branch from 6ad8bf1 to 98957b6 Compare January 16, 2023 22:03
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #27769 (95c1f10) into develop (28dc859) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27769      +/-   ##
===========================================
- Coverage    43.05%   43.03%   -0.03%     
===========================================
  Files          814      817       +3     
  Lines        17189    17234      +45     
  Branches      1921     1934      +13     
===========================================
+ Hits          7401     7416      +15     
- Misses        9526     9553      +27     
- Partials       262      265       +3     
Flag Coverage Δ
e2e 43.03% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@yash-rajpal yash-rajpal marked this pull request as ready for review January 18, 2023 14:21
@yash-rajpal yash-rajpal requested a review from a team as a code owner January 18, 2023 14:21
@tiagoevanp tiagoevanp changed the title [IMPROVE] Create generic upsell modal component [NEW] Create generic upsell modal component Jan 18, 2023
@tiagoevanp tiagoevanp changed the base branch from develop to feat/new-marketplace January 18, 2023 18:48
@tiagoevanp tiagoevanp merged commit 094e190 into feat/new-marketplace Jan 20, 2023
@tiagoevanp tiagoevanp deleted the feat/create-generic-upsell-modal branch January 20, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants