Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Disable video call on read-only rooms for not allowed users #27789

Merged
merged 4 commits into from
Jan 26, 2023

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Jan 18, 2023

Proposed changes (including videos or screenshots)

Jira Issue VC-58

Issue(s)

Steps to test or reproduce

Further comments

gabriellsh
gabriellsh previously approved these changes Jan 18, 2023
@dougfabris dougfabris removed the request for review from pierre-lehnen-rc January 19, 2023 01:08
@dougfabris dougfabris requested a review from a team as a code owner January 24, 2023 20:54
@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Merging #27789 (fd60b00) into develop (da46c23) will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27789      +/-   ##
===========================================
+ Coverage    43.18%   43.35%   +0.16%     
===========================================
  Files          818      818              
  Lines        17147    17147              
  Branches      1945     1945              
===========================================
+ Hits          7405     7434      +29     
+ Misses        9476     9444      -32     
- Partials       266      269       +3     
Flag Coverage Δ
e2e 43.35% <ø> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan added this to the 6.0.0 milestone Jan 26, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 26, 2023
@kodiakhq kodiakhq bot merged commit 7ecedc4 into develop Jan 26, 2023
@kodiakhq kodiakhq bot deleted the fix/disable-call-readonly-rooms branch January 26, 2023 21:38
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants