[NEW] App request phase 2 #27797
Merged
[NEW] App request phase 2 #27797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored RC server rest.js to improve its separation of concerns and correctly differentiate endpoints that need extra permissions from the ones that don’t. Also updated the types in the rest-typings apps index.js file and the uses of these endpoints in the app/client/apps orchestrator.
Finished the first phase of the request flow, removed unnecessary permission locks in order for end users to be able to use marketplace in its entirety and implemented the request button and request modal. Also, implemented all necessary new endpoints.
Solved a bug in which the app menu would show as empty in installed apps in the end user view.
…Rocket.Chat into feat/new-marketplace-request
Fixed a boolean verification that rendered the AppsList section even when it shouldnt.
Removed an unnecessary boolean flag from the AppRow, AppsList and FeaturedAppsSections components.
…ndpoint Created a new RC back-end endpoint that fetch app requests stats from the marketplace api. Also refactored the apps/app-request orchestrator function for simplicity sake.
Added appRequestStats to the info brought from the marketplace API when fetching the published apps list.
Added the user avatar to the requests, formated dates correctly and fixed some uses of tanstack query.
…ketChat/Rocket.Chat into feat/new-marketplace-request-phase-2
- Send endUserID in /apps/marketplace call when current user is an end user(WIP); - Disable request button when current user already requested current app(WIP); - Show Requested apps option on sidebar and kebab menu only when user is admin; - Show unseen app request notification badge to admins only; - Add empty state component to app request tab; - Show upload app and cloud login button to admins only; - Create necessary types and fix small UI issues;
Make the Request button disable when the current user already requested the current app. Also made the request page not show installed apps and fixed the apps pagination component to the bottom of the page.
…ketChat/Rocket.Chat into feat/new-marketplace-request-phase-2
- Stop showing unseen requests badge when there are no unseen/requests; - Disable App Menu request item when the current user already requested a given app; - Improve AppRequestItem layout to work better with color pallete; - Componentize Featured apps, Apps list and Pagination section of AppsPageContent; - Stop retrying app request stats rest call to improve loading speed when there are no stats;
Created a provisory flow that will mark app requests as seen when the user leaves the app requests tabs on the app details page. Once the /markAsSeen endpoint is available on staging, this flow will be reviewed and, maybe, improved.
Implemented a logic flow that mark all app requests accessed by an admin as seen. Also did some refactoring on adjacent components to better function within the flow.
Created some tests to better represent the AppsModelList components now that it has a requested apps page option. Also fixed some already existing tests.
Fixed a bug in which the rest request that marked app requests as seen would enter an infinite loop because of the use of the tanstack query mutation as a dependency for the useEffect hook. Also solved some spacing and color-related problems in the apps page content.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments