Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: DateRangePicker errors #28015

Merged
merged 3 commits into from
Feb 17, 2023
Merged

Regression: DateRangePicker errors #28015

merged 3 commits into from
Feb 17, 2023

Conversation

hugocostadev
Copy link
Contributor

@hugocostadev hugocostadev commented Feb 13, 2023

Proposed changes (including videos or screenshots)

The date range picker for Yesterday, This Week, Previous Week, and This Month in the Message Audit page, was not selecting the correct date range and it was causing form validation issues.

Error Evidence:
Clipboard - February 10, 2023 6_12 PM
Clipboard - February 10, 2023 6_10 PM
Clipboard - February 10, 2023 6_09 PM
Clipboard - February 10, 2023 6_08 PM

Issue(s)

Steps to test or reproduce

  1. As an ADMIN, go to the homepage
  2. Click on the more option tray icon and clicks on Audit > Message
    image
  3. Play around with the Data Range options:
    image

Further comments

TC-466

@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #28015 (e1d50f9) into develop (eac9d4f) will increase coverage by 12.57%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop   #28015       +/-   ##
============================================
+ Coverage    32.32%   44.90%   +12.57%     
============================================
  Files          626      764      +138     
  Lines        12481    14889     +2408     
  Branches      1836     2056      +220     
============================================
+ Hits          4035     6686     +2651     
+ Misses        8248     7916      -332     
- Partials       198      287       +89     
Flag Coverage Δ
e2e 44.86% <ø> (+12.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 16, 2023
@rodrigok rodrigok added this to the 6.0.0 milestone Feb 17, 2023
@rodrigok rodrigok merged commit d400217 into develop Feb 17, 2023
@rodrigok rodrigok deleted the regression/date-picker branch February 17, 2023 01:40
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants