Regression: Emoji picker styling

[yash-rajpal]

Proposed changes (including videos or screenshots)

Before

After

Issue(s)

Steps to test or reproduce

Further comments

[codecov]

Codecov Report

Merging #28046 (dabcc38) into develop (364a153) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head dabcc38 differs from pull request most recent head 6dd6ddf. Consider uploading reports for the commit 6dd6ddf to get more accurate results

@@             Coverage Diff             @@
##           develop   #28046      +/-   ##
===========================================
- Coverage    43.71%   43.69%   -0.02%     
===========================================
  Files          790      790              
  Lines        15258    15261       +3     
  Branches      2084     2085       +1     
===========================================
- Hits          6670     6669       -1     
- Misses        8310     8311       +1     
- Partials       278      281       +3     

Flag	Coverage Δ
e2e	43.69% <ø> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

[sampaiodiego]

what if we have an e2e test to prevent a future regression breaking the emoji picker?

[yash-rajpal]

what if we have an e2e test to prevent a future regression breaking the emoji picker?

We already have an e2e test for testing emoji picker, it is in emojis.spec.ts.

[KevLehman]

what if we have an e2e test to prevent a future regression breaking the emoji picker?

We already have an e2e test for testing emoji picker, it is in emojis.spec.ts.

Why didn't it fail with the regressions then? 👀

[sampaiodiego]

right, so it needs to be improved to be able to catch other regressions like this

[yash-rajpal]

Why didn't it fail with the regressions then? 👀

Because end-to-end tests use selectors to check if element is present in DOM as expected. In this case, all the emojis are present on DOM, just due to some missing css, they are not visible to the user, that is why we were not able to catch this regression using these tests.

I'll try to improve this for such cases.