Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: queuedForUser endpoint not filtering by status #29189

Merged
merged 7 commits into from
Jun 5, 2023

Conversation

KevLehman
Copy link
Member

@KevLehman KevLehman commented May 9, 2023

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

SUP-239

@KevLehman KevLehman requested review from a team as code owners May 9, 2023 17:54
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #29189 (cc0aae1) into develop (74c5f36) will increase coverage by 0.13%.
The diff coverage is n/a.

❗ Current head cc0aae1 differs from pull request most recent head bb65b10. Consider uploading reports for the commit bb65b10 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #29189      +/-   ##
===========================================
+ Coverage    46.73%   46.86%   +0.13%     
===========================================
  Files          698      707       +9     
  Lines        13075    13241     +166     
  Branches      2227     2221       -6     
===========================================
+ Hits          6110     6205      +95     
- Misses        6646     6723      +77     
+ Partials       319      313       -6     
Flag Coverage Δ
e2e 46.82% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

murtaza98
murtaza98 previously approved these changes May 10, 2023
@KevLehman KevLehman added this to the 6.3.0 milestone May 25, 2023
@KevLehman KevLehman requested a review from a team as a code owner May 25, 2023 20:11
@changeset-bot
Copy link

changeset-bot bot commented May 25, 2023

🦋 Changeset detected

Latest commit: bb65b10

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/api-client Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@murtaza98 murtaza98 removed the request for review from a team May 26, 2023 04:22
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jun 5, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jun 5, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jun 5, 2023
@kodiakhq kodiakhq bot merged commit 2945294 into develop Jun 5, 2023
@kodiakhq kodiakhq bot deleted the fix/queued-for-user branch June 5, 2023 14:28
@casalsgh casalsgh removed this from the 6.3.0 milestone Jun 5, 2023
@casalsgh casalsgh modified the milestones: 6.2.3, 6.3.0 Jun 5, 2023
gabriellsh added a commit that referenced this pull request Jun 6, 2023
…importer-messages-not-shown

* 'develop' of github.com:RocketChat/Rocket.Chat:
  fix: Room history scroll position (#29335)
  fix: check for $addToSet to be not empty before passing update params (#29378)
  chore: update `badge-level-0` color (#29460)
  fix: Saving Business hour throws an alert (#29449)
  regression: emojiPicker position (#29408)
  chore: Update codeowners to add ownership of rest typings package to backend (#29437)
  fix: Removed agent access to already taken rooms (#28979)
  fix: `queuedForUser` endpoint not filtering by status (#29189)
  regression: Marketplace Selectors (#29443)
  chore: fix contextualbar size (#29441)
  chore: `ComposerBoxPopup` Items alignment (#29320)
  feat: add support for `MONOLITH_TRANSPORTER` env var (#29373)
  fix: Import progress page stuck at 0% (#29421)
  feat: access-marketplace permission (#29203)
  chore(ddp-client): freeze data emitted by the sdk (#29430)
  refactor: `Table` on Integrations Page (#29428)
  regression: Update `LoadingIndicator` colors (#29424)
  chore(meteor): Update mention style (#29426)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: omnichannel stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants