fix: Application crashes when clicking on Analytics option in Omnichannel view page

[anikdhabal]

Proposed changes (including videos or screenshots)

Issue(s)

fix #29272
OC-953

Steps to test or reproduce

Further comments

[changeset-bot]

🦋 Changeset detected

Latest commit: 21cd09d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codecov]

Codecov Report

Merging #29286 (11f399f) into develop (89e2c26) will increase coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #29286      +/-   ##
===========================================
+ Coverage    46.77%   46.82%   +0.04%     
===========================================
  Files          707      707              
  Lines        13239    13239              
  Branches      2221     2221              
===========================================
+ Hits          6193     6199       +6     
+ Misses        6732     6722      -10     
- Partials       314      318       +4     

Flag	Coverage Δ
e2e	46.79% <ø> (+0.05%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[KevLehman]

Hey! Thanks for the contribution. The PR indeed solves the crash problem, but it also removes the translations for the server-returned strings:

In this case, %_of_conversations should translate to % of conversations (and other languages too) but the string is left as it is. Would you mind checking? 🙌🏽 thanks!

[jayesh-jain252]

The presence of the '%' symbol in the "% of Conversations" at "apps/meteor/packages/rocketchat-i18n/i18n/en.i18n.json" file is probably causing the problem.

Escaping the "%" like this solves the issue

Reference: martinandert/counterpart#37

@KevLehman is this solution accurate and valid?

[anikdhabal]

Hey! Thanks for the contribution. The PR indeed solves the crash problem, but it also removes the translations for the server-returned strings:

In this case, %_of_conversations should translate to % of conversations (and other languages too) but the string is left as it is. Would you mind checking? 🙌🏽 thanks!

sure sir!

[anikdhabal]

Yes, percentage signs need to be escaped with another percentage sign in the json file. Sorry for my mistake.

[murtaza98]

Yes, percentage signs need to be escaped with another percentage sign in the json file. Sorry for my mistake.

Hey @anikdhabal No need to apologize, we're all learning here. Thanks for letting us know about the percentage sign issue in the json file. Could you please inform us when you're done with the suggestion? We appreciate your help! 😊

[anikdhabal]

Yes, percentage signs need to be escaped with another percentage sign in the json file. Sorry for my mistake.

Hey @anikdhabal No need to apologize, we're all learning here. Thanks for letting us know about the percentage sign issue in the json file. Could you please inform us when you're done with the suggestion? We appreciate your help! 😊

Yes sir ☺️,I will fix it by today.