fix: Register Username form showing before homepage #29356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report
@@ Coverage Diff @@
## develop #29356 +/- ##
===========================================
+ Coverage 38.93% 45.66% +6.72%
===========================================
Files 646 693 +47
Lines 12413 12941 +528
Branches 2160 2221 +61
===========================================
+ Hits 4833 5909 +1076
+ Misses 7297 6728 -569
- Partials 283 304 +21
Flags with carried forward coverage won't be shown. Click here to find out more. |
dionisio-bot
bot
added
the
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Jun 1, 2023
…e/system-messages-update * 'develop' of github.com:RocketChat/Rocket.Chat: (26 commits) fix: Importer crashes when sending the "active status" e-mail notification to users (#29401) docs: new README file (#27955) refactor: replace with new `Select` (#29368) fix: Sidebar's sort by name not being checked properly (#29415) fix: Login Terms custom content (#28999) fix: Broken link fixed inside webhook menu (#29048) fix: Apps settings i18n translation (#29394) fix: OTR session closing after 10 seconds without warning (#29245) fix: Register Username form showing before homepage (#29356) regression(ui-client): Toolbox action button badge in the wrong position (#29412) fix: marketplace filters are changing size (#28738) chore: Update highlighted word color (#29407) i18n: Language update from LingoHub 🤖 on 2023-05-22Z (#29317) chore(ddp-sdk): ts-jest -> swc/jest (#29380) chore: `ToolboxAction` pressed state (#29397) chore: add logs to recurring omnichannel cron jobs (#29392) regression: `t` using always sprintf (#29396) fix: fix wrong %s translations (#29395) regression(push): fix error when selecting what to import (#29289) chore: Change ddpsdk.stream to return subscription (#29375) ...
aleksandernsilva
pushed a commit
that referenced
this pull request
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Meteor Minimongo Collection was causing delays in populating user data in the front end, causing layout updates with different rules (the username was not being sent to UI the first time sending the user to the username registration form).
To avoid the incomplete stream from Meteor, I used the REST endpoint with the existing hook to get user info to get the full user data and check whether it has a username or not.
Issue(s)
Steps to test or reproduce
Further comments
WM-46