Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplified canned response filter query #29650

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Jun 26, 2023

Proposed changes (including videos or screenshots)

Issue(s)

OC-1045

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Jun 26, 2023

⚠️ No Changeset found

Latest commit: 51b31ba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jun 26, 2023
@aleksandernsilva aleksandernsilva marked this pull request as ready for review June 26, 2023 20:13
@aleksandernsilva aleksandernsilva requested a review from a team as a code owner June 26, 2023 20:14
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #29650 (51b31ba) into develop (610f3e9) will increase coverage by 4.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #29650      +/-   ##
===========================================
+ Coverage    42.51%   46.63%   +4.11%     
===========================================
  Files          629      692      +63     
  Lines        11614    12928    +1314     
  Branches      2078     2236     +158     
===========================================
+ Hits          4938     6029    +1091     
- Misses        6396     6576     +180     
- Partials       280      323      +43     
Flag Coverage Δ
e2e 46.61% <ø> (+4.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@kodiakhq kodiakhq bot merged commit e527f51 into develop Jun 26, 2023
@kodiakhq kodiakhq bot deleted the refactor/canned-responses-filter branch June 26, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants