Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace Menu in favor of GenericMenu in AdminUsers #34834

Merged
merged 3 commits into from
Dec 27, 2024

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Dec 26, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

ARCH-1401

Copy link
Contributor

dionisio-bot bot commented Dec 26, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.3.0, but it targets 7.2.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Dec 26, 2024

⚠️ No Changeset found

Latest commit: 96ae7b6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris added this to the 7.3.0 milestone Dec 26, 2024
Copy link
Contributor

github-actions bot commented Dec 26, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34834/
on branch gh-pages at 2024-12-27 13:48 UTC

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.36%. Comparing base (1184b83) to head (96ae7b6).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #34834      +/-   ##
===========================================
- Coverage    59.37%   59.36%   -0.02%     
===========================================
  Files         2819     2819              
  Lines        67691    67652      -39     
  Branches     15036    15022      -14     
===========================================
- Hits         40192    40159      -33     
+ Misses       24682    24678       -4     
+ Partials      2817     2815       -2     
Flag Coverage Δ
unit 75.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris marked this pull request as ready for review December 26, 2024 19:48
@dougfabris dougfabris requested a review from a team as a code owner December 26, 2024 19:48
@tassoevan tassoevan force-pushed the refactor/menu-adminUsers branch from 0365449 to 96ae7b6 Compare December 27, 2024 13:44
@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Dec 27, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 27, 2024
@kodiakhq kodiakhq bot merged commit e229533 into develop Dec 27, 2024
51 checks passed
@kodiakhq kodiakhq bot deleted the refactor/menu-adminUsers branch December 27, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants