Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipboard [Firefox version < 50] #6280

Merged
merged 3 commits into from
Mar 29, 2017
Merged

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Mar 7, 2017

@RocketChat/core
Closes #2087
I create a hack that fix the problem, I'm not sure if is necessary yet, but ....
I think this pull request must be done here to.

@@ -5,6 +5,7 @@
{{#if allowedToSend}}
<div class="message-input border-component-color">
<div class="input-message-container content-background-color">
<div id='msg_contenteditable' contenteditable='true' style='height: 0; width: 0; overflow: hidden'></div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use double quotes here.

@engelgabriel engelgabriel requested a review from karlprieb March 8, 2017 18:55
@engelgabriel engelgabriel added this to the 0.54.0 milestone Mar 8, 2017
Copy link
Contributor

@karlprieb karlprieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its ok for me, just adjust the single quotes :)

@ggazzo
Copy link
Member Author

ggazzo commented Mar 8, 2017

I think that pull request fix this issue #862 to.

@karlprieb
Copy link
Contributor

karlprieb commented Mar 8, 2017

@ggazzo Yes, it will fix :) We tested this copy-paste yesterday.

@engelgabriel engelgabriel modified the milestones: 0.54.0, 0.55.0 Mar 22, 2017
@rodrigok
Copy link
Member

@graywolf336 can you review this again?

@engelgabriel engelgabriel merged commit c99e40b into RocketChat:develop Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clipboard
5 participants