Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

converted slashcommand-me coffee to js #6468

Merged
merged 3 commits into from
Mar 29, 2017

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Mar 24, 2017

@RocketChat/core

@engelgabriel
Copy link
Member

I think you forgot to delete the old file.

@ggazzo
Copy link
Member Author

ggazzo commented Mar 24, 2017

@engelgabriel fixed

* Me is a named function that will replace /me commands
* @param {Object} message - The message object
*/
const Me = function(command, params, item) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use named functions instead of variables?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please, as that helps with stacktraces so that the functions in the traces are named and not "anonymous"

@engelgabriel engelgabriel modified the milestone: 0.55.0 Mar 29, 2017
@engelgabriel engelgabriel merged commit 0c21399 into RocketChat:develop Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants