Move room display name logic to roomType definition #6585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampaiodiego
changed the title
sampaiodiego
force-pushed
the
move-room-display-name-logic-to-roomType-definition
branch
from
e7aa7ed to
d83e491
Compare
sampaiodiego
changed the title
|
Now it's good to be reviewed. 👍 |
rodrigok
approved these changes
Apr 5, 2017
engelgabriel
deleted the
move-room-display-name-logic-to-roomType-definition
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
The new logic introduced by #3851 broke livechat room titles, so I moved the logic to the specific roomType definition.