[NEW] Drupal oAuth Integration for Rocketchat #6632
Conversation
…english in this packege until acceptation to keep it as a single package.
…dy for integration into Rocketchat.
|
|
- Changed colorhex to lower case.
|
@Lawri-van-Buel thanks for contributing! Do you happen to have a link to the Rocket.Chat Drupal integration module you mentioned? I'd love to check it out. |
| @@ -137,6 +137,7 @@ rocketchat:crowd@1.0.0 | |||
| rocketchat:custom-oauth@1.0.0 | |||
| rocketchat:custom-sounds@1.0.0 | |||
| rocketchat:dolphin@0.0.2 | |||
| rocketchat:drupal@0.0.1 | |||
There was a problem hiding this comment.
Can you undo all other changes to this file but this line here? Ideally this PR shouldn't be updating other packages, it should only be adding the code needed for drupal. We'd handle the updating of packages seperately
There was a problem hiding this comment.
I agree I though I had done just that, Will do with the new update as its base.
.meteor/packages
Outdated
| jquery@1.11.10 | ||
| less@2.7.9 | ||
| logging@1.1.17 | ||
| meteor-base@1.0.4 | ||
| mobile-experience@1.0.4 | ||
| mongo@1.1.15 | ||
| mongo@1.1.16 |
There was a problem hiding this comment.
Can you undo changes to this file? Like mentioned in the other comment, ideally we'd handle these types of updates in a seperate PR. This should only about adding drupal. Thx 👍
…ough the official channels and not this PR
|
@geekgonecrazy My drupal 7 module is on the Drupal.org Repo, I am writing some documentation before I will release the drupal module (should be sometime the coming week) as for the development version its the latest drupal dev version on drupal.org |
|
@geekgonecrazy can you confirm the issues are resolved? or have I missed something? |
.meteor/packages
Outdated
| @@ -170,3 +170,5 @@ yasaricli:slugify | |||
| yasinuslu:blaze-meta | |||
| deepwell:bootstrap-datepicker2 | |||
| rocketchat:google-natural-language | |||
| rocketchat:drupal | |||
| rocketchat:i18n | |||
There was a problem hiding this comment.
Was it necessary to add this? I think our other packages might just add this as a dependency.
@RocketChat/core is there a reason it's not in the packages list?
There was a problem hiding this comment.
not sure. I just used the build example and added rocketchat:drupal using the meteor add rocketchat:drupal command. that I take it added the lines to the package. I am new to meteor, but expierenced in drupal so do not be afraid to tell me i did something wrong ;) I prefer to do it right than muddle on in a 'wrong' way.
|
@Lawri-van-Buel awesome I'll check it out. Just will want to get feedback from more of the team, then get it merged 👍 |
|
great I'll await yours and their review |
|
Is this now ready to be merged or do you want me to change something still? |
|
@sampaiodiego / @rodrigok only change i'm not sure about is that rocketchat:i18n was added to .meteor/packages it wasn't before. |
|
@geekgonecrazy only top level packages are added to but this doesn't explain why it was added after a btw, I don't think by just having the file |
|
Updated my fork with the removal of the i18n line in .meteor/packages and moving the translatable strings to the i18n module. |
|
@sampaiodiego please let's include this on the next candidate release. |
|
This is amazing! Great work :) |
@RocketChat/core
Updates issue #1921
This adds an easy to use Drupal oauth integration path and is the rocketchat part of the new rocketchat drupal integration module on drupal.org (version 7.x-1.1) that will soon be released. It will allow you to use Drupal as a Login provider for your rocketchat users.