Converted rocketchat-lib 3 #6672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into rocketchat-lib3
…nto rocketchat-lib3
…nto rocketchat-lib3
rodrigok
requested changes
Apr 20, 2017
| @@ -0,0 +1,102 @@ | |||
| /* globals fireGlobalEvent readMessage*/ | |||
| const openRoom = function(type, name) { | |||
There was a problem hiding this comment.
Do not remove the global var currentTracker
| return _(actions).reduceRight(_.wrap, (err, success) => callback(err, success))(); | ||
| }, | ||
| load(key, value, initialLoad) { | ||
| Object.keys({ |
rodrigok
requested changes
Apr 27, 2017
| } | ||
| }); | ||
|
|
||
| if (room && !room.t) { |
There was a problem hiding this comment.
If room is undefined the code will continue and 3 lines below the assign from room.t will thrown an exception
| t: 1 | ||
| } | ||
| }); | ||
| if (room && !room.t) { |
…nto rocketchat-lib3
rodrigok
approved these changes
Apr 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge #6593 first