Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] overlapping text for users-typing-message #6999

Merged
merged 1 commit into from
May 17, 2017

Conversation

darkv
Copy link
Contributor

@darkv darkv commented May 17, 2017

@RocketChat/core

Beneath the message input field there is a line with formatting tips. If a user in a chat room starts to type a message a user-typing-hint is shown. If the width of the browser window is too narrow that hint will overlay the formatting tips making it hard to read. This patch just sets the background color of the hint element to white to preserve readability.

screenshot

@CLAassistant
Copy link

CLAassistant commented May 17, 2017

CLA assistant check
All committers have signed the CLA.

@rodrigok rodrigok requested a review from karlprieb May 17, 2017 18:45
@rodrigok rodrigok merged commit 00dbd3d into RocketChat:develop May 17, 2017
@rodrigok rodrigok added this to the 0.57.0 milestone May 17, 2017
@jthomae1
Copy link

jthomae1 commented Aug 7, 2017

After our last update (0.57.2), I discovered an always visible white bar beneath the message input. It did not take much time to connect this behavior to the "Fix" #6999.

bildschirmfoto 2017-08-07 um 11 03 52

Maybe it's a personal view, but I don't think that this behavior should be the default setting.

It can be changed, if you set the background for the div in the Custom CSS section of the Layout config:
.message-form .users-typing {
background-color: << Insert content-background-color >> !important;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants