Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Real permissions names and descriptions #7242

Merged
merged 8 commits into from
Jun 30, 2017
Merged

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Jun 13, 2017

@RocketChat/core

Closes #4371

This adds translatable names and descriptions to the permissions

selection_007

also this PR will sort alphabetically the en.i18n.js file

Update: Display the technical permission name too
screenshot from 2017-06-13 14-31-59

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7242 June 13, 2017 17:00 Inactive
@geekgonecrazy
Copy link
Contributor

People are going to love this! :)

@graywolf336
Copy link
Contributor

This has been much needed for a long time.

Only issue I have so far is the language of the descriptions of the permissions. Permission to seems like it would be implied since they're on the permission screen?

Also, will there be a way for people to see the technical permission anymore? Say they get an error and find the permission name needed but then they come to this screen and can't find it

@MartinSchoeler
Copy link
Contributor Author

@graywolf336 I agree with you, but I'm not sure how this should be written. Any ideas?

@gdelavald
Copy link
Contributor

We could add a simple 'Localization String [error-code]' like this error message:
image

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7242 June 13, 2017 17:33 Inactive
@MartinSchoeler
Copy link
Contributor Author

Also if you guys could take a look in the descriptions to see if I got them right. In this commit is easier to read the changes ba35741

@graywolf336 graywolf336 changed the title [NEW]Real permissions names and descriptions [NEW] Real permissions names and descriptions Jun 13, 2017
"manage-oauth-apps": "Manage Oauth Apps",
"manage-oauth-apps_description": "Permission to manage the server Oauth apps",
"manage-own-integrations": "Manage Own Integrations",
"manage-own-integrations_description": "Permition to users create and edit their own integration or webhooks",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Permition to users

Should be

Permission to allow users to

"post-readonly": "Post ReadOnly",
"post-readonly_description": "Permission to post a message in a read-only channel",
"preview-c-room": "Preview Public Channel",
"preview-c-room_description": "Permission view the contents of a public channel before joining",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Permission view

should be

Permission to view

"unarchive-room": "Unarchive Room",
"unarchive-room_description": "Permission to unarchive channels",
"user-generate-access-token": "User Generate Access Token",
"user-generate-access-token_description": "Permission to users generate access tokens",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Permission to users

Should be

Permission for users to

"view-p-room": "View Private Room",
"view-p-room_description": "Permission to view private channels",
"view-privileged-setting": "View Privileged Setting",
"view-privileged-setting_description": "Permission to view settings",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Permission to view settings

should probably be:

Permission to view privileged settings

"view-privileged-setting_description": "Permission to view settings",
"view-room-administration": "View Room Administration",
"view-room-administration_description": "Permission to view public, private and direct message statistics. Does not include the ability to view conversations or archives",
"view-statistics": "View Private Room",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be:

View Statistics

@MartinSchoeler
Copy link
Contributor Author

Thanks for helping out with the typos @geekgonecrazy

@geekgonecrazy
Copy link
Contributor

@MartinSchoeler 👍 with those it looks good to me. Massive improvement over what we have now, that's for sure!

@rodrigok
Copy link
Member

@MartinSchoeler Can you fix the conflicts? Probably is better to not sort the lines in your PR

@MartinSchoeler MartinSchoeler force-pushed the real-permissions-names branch from 8f9664b to a5a3e27 Compare June 30, 2017 20:15
@rodrigok rodrigok added this to the 0.58.0 milestone Jun 30, 2017
@rodrigok rodrigok merged commit ab6ceba into develop Jun 30, 2017
@rodrigok rodrigok deleted the real-permissions-names branch June 30, 2017 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants