Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix hiding flex-tab on embedded view #7486

Merged
merged 1 commit into from
Jul 17, 2017

Conversation

sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Jul 13, 2017

@RocketChat/core

Using the embedded view mode (appending ?layout=embedded to the URL) the flex-tab should be hidden. This behavior was changed by #7448

Before:
image

After:
image

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7486 July 13, 2017 14:46 Inactive
@sampaiodiego sampaiodiego requested review from ggazzo and karlprieb July 13, 2017 14:47
@sampaiodiego sampaiodiego changed the title Fix hiding flex-tab on embedded view [FIX] Fix hiding flex-tab on embedded view Jul 13, 2017
@sampaiodiego sampaiodiego requested a review from gdelavald July 13, 2017 15:04
& .messages-container {
border-width: 0;

& .flex-tab-container {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a selector, you have a space after that dot.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 I don't get it.. there is no space after the dot and it's exactly the same as all other selectors =)

also you can see it working on heroku and the selector being used by google chrome:
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the flex-tab-container is a child of messages-container you don't need the & there

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, is that correct or not?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rodrigok @sampaiodiego it's correct, idk why but I saw a space after the dot yesterday.

@gdelavald actually you need to put & before. We are using this css nesting draft on our implementation

& .messages-container {
border-width: 0;

& .flex-tab-container {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rodrigok @sampaiodiego it's correct, idk why but I saw a space after the dot yesterday.

@gdelavald actually you need to put & before. We are using this css nesting draft on our implementation

@engelgabriel engelgabriel merged commit 712dbc4 into develop Jul 17, 2017
@engelgabriel engelgabriel deleted the fix-tabbar-embedded-mode branch July 17, 2017 23:44
@engelgabriel engelgabriel modified the milestone: 0.58.0 Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants