Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Prevent new room status from playing when user status changes #7487

Merged
merged 1 commit into from
Jul 14, 2017

Conversation

sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Jul 13, 2017

@RocketChat/core

Fix new room sound notification playing when any user data changes (the status is the most common)

sound webm

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7487 July 13, 2017 15:15 Inactive
@geekgonecrazy
Copy link
Contributor

Wow! So that's what was happening! I was trying to figure out why I would ocassionally hear that ding again 😁

@rodrigok rodrigok added this to the 0.58.0 milestone Jul 14, 2017
@rodrigok rodrigok merged commit 9a68ad9 into develop Jul 14, 2017
@rodrigok rodrigok deleted the fix-new-room-sound-when-status-changes branch July 14, 2017 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants