Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Wrong email subject when "All Messages" setting enabled #7639

Merged
merged 3 commits into from
Aug 8, 2017

Conversation

MartinSchoeler
Copy link
Contributor

@RocketChat/core

This adds a email title for when you set the all messages email notifications preferences
screen shot 2017-08-01 at 4 23 19 pm

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7639 August 2, 2017 13:13 Inactive
@rodrigok rodrigok changed the title [NEW] All Messages email notifications [FIX] All Messages email subject Aug 2, 2017
@rodrigok rodrigok modified the milestones: 0.58.0-rc.1, 0.57.3 Aug 2, 2017
@rodrigok rodrigok changed the title [FIX] All Messages email subject [FIX] Wrong email subject when "All Messages" setting enabled Aug 8, 2017
@rodrigok rodrigok merged commit c409e41 into develop Aug 8, 2017
@rodrigok rodrigok deleted the all-messages-email branch August 8, 2017 17:54
rodrigok added a commit that referenced this pull request Aug 8, 2017
[FIX] Wrong email subject when "All Messages" setting enabled
@pkgodara
Copy link
Contributor

pkgodara commented Aug 16, 2017

@MartinSchoeler After I merged it in #7342 & modified to https://github.com/RocketChat/Rocket.Chat/pull/7342/files#diff-c2dd35e772b329dfcbed709e79e56805 , for enabling subject editing, email notifications are not being sent for mentions in channels. In DMs, it works fine. User preferences is Every mention/DM.

@pkgodara
Copy link
Contributor

Now I changed Email option under Notifications on right tab of channel & set it to Mentions then I'm getting emails. Seems a bug. -_-

@MartinSchoeler
Copy link
Contributor Author

@pkgodara Yes that is a bug on this pr, im pretty sure this will fix it #7754

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants