Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix avatar upload fail on Cordova app #7656

Merged

Conversation

ccfang
Copy link
Contributor

@ccfang ccfang commented Aug 4, 2017

@RocketChat/core

When uploading avatar on Cordova app, Android or iOS, it can't work and appear js error below:
screenshot - 2017_8_4 02_03_30

Clicking the error code, found the error near the "for...of" loop:
screenshot - 2017_8_4 02_06_43

So i changed the for...of loop to the normal for loop, and it work fine.

@rodrigok rodrigok added this to the 0.57.4 milestone Aug 8, 2017
@rodrigok rodrigok merged commit c56f09b into RocketChat:develop Aug 8, 2017
@ccfang ccfang deleted the fix-avatar-upload-error-cordova branch August 9, 2017 00:39
@engelgabriel engelgabriel modified the milestones: 0.58.0, 0.57.4 Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants