[FIX] Text area buttons and layout on mobile #7985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampaiodiego
requested changes
Aug 30, 2017
| @@ -174,8 +181,58 @@ | |||
| &__container { | |||
| display: flex; | |||
|
|
|||
| padding: 1rem 1rem calc(1rem - 8px) 1rem; | |||
| } | ||
| }; | ||
|
|
||
| Template.messageBox__actions.helpers({...methods}); |
There was a problem hiding this comment.
you can pass methods variable directly, don't need to spread it into another object
There was a problem hiding this comment.
I know, but we are suggesting that we can put more functions inside.
There was a problem hiding this comment.
I`m sorry sir @sampaio.diego, you are right.
| }; | ||
|
|
||
| Template.messageBox__actions.helpers({...methods}); | ||
| Template.messageBox__actionsSmall.helpers({...methods}); |
| sendIcon() { | ||
| return Template.instance().sendIcon.get(); | ||
| disableSendIcon() { | ||
| console.log(Template.instance().sendIcon.get()); |
| @@ -9,8 +9,7 @@ | |||
| return this.filter('textarea').each(function() { | |||
| var self = this; | |||
| var $self = $(self); | |||
| var minHeight = $self.height(); | |||
| var noFlickerPad = $self.hasClass('autogrow-short') ? 0 : parseInt($self.css('lineHeight')) || 0; | |||
| var minHeight = 16; //$self.height(); | |||
| @@ -54,9 +56,9 @@ | |||
| } | |||
|
|
|||
| shadow.css('width', $self.width()); | |||
| shadow.html(val + (noFlickerPad === 0 ? '...' : '')); // Append '...' to resize pre-emptively. | |||
| shadow.html(val); // Append '...' to resize pre-emptively. | |||
There was a problem hiding this comment.
the comment does not make sense anymore
There was a problem hiding this comment.
your brain gets smart but your head gets dumb 🎶
| const methods = { | ||
| actions() { | ||
| const groups = RocketChat.messageBox.actions.get(); | ||
| console.log(Object.keys(groups).reduce((ret, el) => ret.concat(groups[el]), [])); |
ggazzo
force-pushed
the
text-area-mobile
branch
from
cb84955 to
b5fadc8
Compare
ggazzo
force-pushed
the
text-area-mobile
branch
from
b5fadc8 to
12311ae
Compare
ggazzo
force-pushed
the
text-area-mobile
branch
from
12311ae to
433be20
Compare
rodrigok
changed the title
rodrigok
approved these changes
Aug 30, 2017
sampaiodiego
approved these changes
Aug 30, 2017
rodrigok
added a commit
that referenced
this pull request
Aug 30, 2017
[FIX] Text area buttons and layout on mobile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #7935